Conversation
|
Don’t use 0.0.0.0 in the browser. Use localhost.
…On Mon, Oct 27, 2025 at 6:58 PM Nitin Magima ***@***.***> wrote:
@nitinmagima <https://github.com/nitinmagima> requested your review on:
#575 <#575> Madagascar
custom shapefile.
—
Reply to this email directly, view it on GitHub
<#575 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF3DRS2OOPEL3JE63CEWR33Z2PQNAVCNFSM6AAAAACKMBBWMKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQGUZTQMBUHE4DMNA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Seems like there's still a format issue even when all three layers exist. No errors are generated when the map is loaded. I'm guessing it's something to how fiona is reading the new shapefiles. Does it expect it it to have a particular hierarchy? |
|
I found three distinct problems:
I've pushed changes to this branch to fix 1 and 3. @nitinmagima please pull my changes, and then see if you can figure out how to reproject/deproject the shapes. Also please share your script for constructing and deprojecting the shapes, because eventually I'd like to put that logic in the application. If the application can handle shapes in whatever form we find them, rather than requiring pre-processing, it will make it easier to add new shapes. |
|
@mm5330 @nitinmagima what is going on? Github says Max just pushed two commits authored by Nitin that duplicate work Max did on a different branch. There should be nothing about Ethiopia on this branch. This branch is for Madagascar changes. |
Oh weird, this wasn't me. Not sure how that happened... |
|
Hi Aaron,
So changing the coordinate system worked but the boundaries themselves look
weird. I'm wondering if that has to do with the data. Both the zip files
and the shapefiles work now but there's an error.
Traceback (most recent call last):
File "/home/magima/python-maprooms/fbfmaproom/fbfmaproom.py", line 1144,
in table_cb
raise Exception("No region found")
Exception: No region found
[image: image.png]
Here's the code I'm using -
https://drive.google.com/file/d/1G4oUoik09moCe7QvvLnmaUGfeFKd3PuY/view?usp=sharing
I pulled in changes from the main branch, I'm guessing that's where Max's
comments got pulled in.
Best,
Nitin
…On Thu, Oct 30, 2025 at 2:53 PM Aaron Kaplan ***@***.***> wrote:
aaron-kaplan left a comment (iridl/python-maprooms#575) I found three
distinct problems: The zip file doesn't have the structure that fiona
expects. I'm not sure how it should be structured, so for now I've unpacked
the zip. The Madagascar shapes
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
*aaron-kaplan* left a comment (iridl/python-maprooms#575)
<https://urldefense.com/v3/__https://github.com/iridl/python-maprooms/pull/575*issuecomment-3469592438__;Iw!!BDUfV1Et5lrpZQ!Qz6_PFBBhyjU04WzH0EronD38rjTXqVOZjP-EesrPt30LuqxpBN5JzBKTVX5C2YWnGDV94o0OyPc-yddHAdHcT1onPzrRw$>
I found three distinct problems:
1. The zip file doesn't have the structure that fiona expects. I'm not
sure how it should be structured, so for now I've unpacked the zip.
2. The Madagascar shapes are in a projected coordinate system, with
units of meters, whereas the application expects a geographic coordinate
system, with units of degrees. The Djibouti shapes worked because they use
a geographic coordiate system.
3. A bug in the application code caused the error mesage to be
silently discarded instead of being printed on the console.
I've pushed changes to this branch to fix 1 and 3. @nitinmagima
<https://urldefense.com/v3/__https://github.com/nitinmagima__;!!BDUfV1Et5lrpZQ!Qz6_PFBBhyjU04WzH0EronD38rjTXqVOZjP-EesrPt30LuqxpBN5JzBKTVX5C2YWnGDV94o0OyPc-yddHAdHcT2BpSj9qg$>
please pull my changes, and then see if you can figure out how to
reproject/deproject the shapes.
Also please share your script for constructing and deprojecting the
shapes, because eventually I'd like to put that logic in the application.
If the application can handle shapes in whatever form we find them, rather
than requiring pre-processing, it will make it easier to add new shapes.
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/iridl/python-maprooms/pull/575*issuecomment-3469592438__;Iw!!BDUfV1Et5lrpZQ!Qz6_PFBBhyjU04WzH0EronD38rjTXqVOZjP-EesrPt30LuqxpBN5JzBKTVX5C2YWnGDV94o0OyPc-yddHAdHcT1onPzrRw$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AFK3DJL4DK2LBHF226WKWIT32JNC3AVCNFSM6AAAAACKMBBWMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINRZGU4TENBTHA__;!!BDUfV1Et5lrpZQ!Qz6_PFBBhyjU04WzH0EronD38rjTXqVOZjP-EesrPt30LuqxpBN5JzBKTVX5C2YWnGDV94o0OyPc-yddHAdHcT21bjMjUQ$>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Best,
________________________________
*Nitin Magima (he/him/his) *
Staff Associate II, Officer of Research
MPA DP | FSA Credential Holder | AWS Certified Cloud Practitioner
National Center for Disaster Preparedness (NCDP) <http://ncdp.columbia.edu>
| Affiliate of IRI
Columbia Climate School | Columbia University
Office: 212.853.NCDP
E-mail: ***@***.***
Medium ***@***.***> | Github
<https://github.com/nitinmagima> | LinkedIn
<https://www.linkedin.com/in/nitin-magima/>
|
54337df to
a29f0da
Compare
|
I've added Nitin's script to this repo, and modified it to remove the holes that http://mako.iri.columbia.edu:9998/fbfmaproom/madagascar A couple things to note:
@dantesab9 let me know what you want to do. |
|
BTW I rebased this branch to get rid of the weird repeated commits from Max. If you pulled it before and you try to pull again, it will get complicated. I don't think anyone needs to do that, but if you do, I can help. |
|
Hi Aaron, thank for this update too, the map look very good! About the obs data coverage, I think it is best to extend to the full country since we will use some districts that are not in the prior "national" polygon and also we may need to provide data for more northern districts that are part of the other, newer, red cross project. I'll take a look at the latitude question and also start working in updating the polygon IDs in the markdowns. |
|
@dantesab9 are we making progress towards merging this? I just referred Max to it as an example to follow for Ethiopia, and I presume others will follow eventually. It would be good to get it into the main branch so it doesn't get out of sync with the rest of the code. |
Hi Aaron,
I update the yaml file to take in the new shapefiles where the new admin 0 and 1 shapefiles have been created using the admin 2 files. On running the dashboard in the server however I get this error. It doesn't seem like a code error but a server error?
Best,
Nitin